Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove base64 and nkf which conflict with default gems #855

Merged
merged 3 commits into from
May 30, 2024
Merged

Remove base64 and nkf which conflict with default gems #855

merged 3 commits into from
May 30, 2024

Conversation

tlehman
Copy link
Contributor

@tlehman tlehman commented May 23, 2024

Testing

I built this and confirmed there are no duplicates of these standard gems:

[root@perky-artillery gems]# ls | grep nkf
nkf-0.1.2
[root@perky-artillery gems]# ls | grep base
base64-0.1.1

@tlehman tlehman requested review from a team as code owners May 23, 2024 00:08
@joshcooper
Copy link
Contributor

joshcooper commented May 23, 2024 •
edited
Loading

base64 is a default gem for ruby 3.2.2 so that part seems fine https://stdgems.org/3.2.2/#bundled-gems

But nkf is not. It be good to understand why it was added as a dependency and what might break if we remove it. I'm guessing it was for CFPropertyList based on https://rubygems.org/gems/nkf/reverse_dependencies?

@tlehman
Copy link
Contributor Author

tlehman commented May 23, 2024

But nkf is not. It be good to understand why it was added as a dependency and what might break if we remove it. I'm guessing it was for CFPropertyList based on https://rubygems.org/gems/nkf/reverse_dependencies?

It's under ext/, not sure why it was added, but I'll look into it

@tlehman
Copy link
Contributor Author

tlehman commented May 29, 2024

@joshcooper I just checked https://stdgems.org/nkf/ and it's a default gem. I also just built this branch and verified that it includes nkf 0.1.2 (only), so this branch is ready to merge.

donoghuc
donoghuc approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI should be green now. I think this is g2g.

@joshcooper joshcooper merged commit dd06b4f into puppetlabs:master May 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donoghuc donoghuc donoghuc approved these changes

@joshcooper joshcooper joshcooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlehman @joshcooper @donoghuc